Skip to content

migrate instrumentation sample to otlphttp #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dashpole merged 7 commits into from
Dec 8, 2025
Merged

migrate instrumentation sample to otlphttp #459

dashpole merged 7 commits into from
Dec 8, 2025
+35 −17

Conversation

@dashpole
Copy link
Contributor

@dashpole dashpole commented Dec 4, 2025

@dashpole dashpole requested a review from a team as a code owner December 4, 2025 01:43
@dashpole dashpole force-pushed the instrumentation_otelhttp branch from 962775b to 42325d3 Compare December 4, 2025 18:36
@dashpole dashpole mentioned this pull request Dec 4, 2025
Merged
@dashpole dashpole force-pushed the instrumentation_otelhttp branch from 24046c7 to f6fd7b8 Compare December 5, 2025 21:19
@dashpole
Copy link
Contributor Author

dashpole commented Dec 5, 2025

@aabmass I'm having trouble getting to the bottom of this. It now passes for me locally, but still fails during the presubmit with the same generic error.

When I was testing, the error was because the collector was not able to start. Maybe GOOGLE_CLOUD_PROJECT isn't set?

@dashpole
Copy link
Contributor Author

dashpole commented Dec 5, 2025

Does it need to map PROJECT_ID to that?

@DylanRussell
Copy link
Contributor

DylanRussell commented Dec 8, 2025

I can't tell why golang:1.25 failed..

@dashpole
Copy link
Contributor Author

dashpole commented Dec 8, 2025 

   2025-12-08T18:06:33.095Z	warn	[email protected]/provider.go:59	Configuration references unset environment variable	{"name": "GOOGLE_CLOUD_PROJECT"}
   2025-12-08T18:06:33.095Z	warn	[email protected]/provider.go:59	Configuration references unset environment variable	{"name": "GOOGLE_CLOUD_PROJECT"}
   2025-12-08T18:06:33.095Z	warn	[email protected]/provider.go:59	Configuration references unset environment variable	{"name": "GOOGLE_CLOUD_PROJECT"}
   2025-12-08T18:06:33.095Z	warn	[email protected]/provider.go:59	Configuration references unset environment variable	{"name": "GOOGLE_CLOUD_PROJECT"}
   2025-12-08T18:06:33.095Z	warn	[email protected]/provider.go:59	Configuration references unset environment variable	{"name": "GOOGLE_CLOUD_PROJECT"}
   Error: failed to build pipelines: failed to create "resource/gcp_project_id" processor, in pipeline "traces": error creating AttrProc. Either field "value", "from_attribute" or "from_context" setting must be specified for 0-th action
   2025/12/08 18:06:33 collector server run finished with error: failed to build pipelines: failed to create "resource/gcp_project_id" processor, in pipeline "traces": error creating AttrProc. Either field "value", "from_attribute" or "from_context" setting must be specified for 0-th action

@dashpole dashpole force-pushed the instrumentation_otelhttp branch from ab33060 to 5fdb3af Compare December 8, 2025 19:07
@dashpole dashpole merged commit 4aa992f into GoogleCloudPlatform:main Dec 8, 2025
21 checks passed
dashpole added a commit that referenced this pull request Dec 8, 2025
@dashpole
Revert "migrate instrumentation sample to otlphttp (#459)"
6f95de8 
This reverts commit 4aa992f.
@dashpole dashpole deleted the instrumentation_otelhttp branch December 8, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DylanRussell DylanRussell DylanRussell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dashpole @DylanRussell